Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multitouch support #34

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

doctadre
Copy link

@doctadre doctadre commented May 4, 2016

Needed multi touch support, and originally thought the multi-touch repo was iOS only because of the iOS folder. Looks like from the issues it doesn't work on android anyway, so here we are. Feedback appreciated.

  • Supports two sliders
  • Update callback to return both values
  • Deprecate minimumTrackTintColor and maximumTrackTintColor in favor of trackColor and trackHighlight color
  • Moved render to bottom of file to make it easier to find ^_^
  • updated Example to show off new multi touch
  • Updated readme to support these changes

…f file, deprecate old highlight props, update example/readme
@sospedra
Copy link

will this be merged?

@tyherox
Copy link

tyherox commented Jun 27, 2018

Hey how is this merge-conflict looking? Any plans on merging this soon? Would love to help if any is needed.

@doctadre
Copy link
Author

Merge conflicts have been resolved, made changes to improve detecting which slider is being touched when they are close together.

@anagar23
Copy link

anagar23 commented Oct 3, 2018

Is this PR merged?

@muraterd
Copy link

muraterd commented Mar 4, 2019

Any update on this?

@doctadre
Copy link
Author

doctadre commented Mar 4, 2019

I don't think the author is supporting this repo anymore since he hasn't merged anything in a long time. That being said I also don't have time to resolve conflicts on this but if anyone else wants to take over, feel free.

@muraterd
Copy link

muraterd commented Mar 5, 2019

@jgornick made a new PR #142 and it has no conflict. But as you mentioned this repo is not supported anymore.

@kesha-antonov
Copy link

@jellyninjadev
Copy link

jellyninjadev commented Apr 19, 2019

@doctadre any plans resolving conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants