Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): 移除非必要的 modelValue 更新 #3080

Closed
wants to merge 1 commit into from
Closed

fix(input): 移除非必要的 modelValue 更新 #3080

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions src/packages/__VUE/input/input.taro.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,6 @@ const _onInput = (event: Event) => {
}

const updateValue = (value: string, trigger: InputFormatTrigger = 'onChange') => {
// #2178 & Taro #2642
emit('update:modelValue', value)
if (props.maxLength && value.length > Number(props.maxLength)) {
value = value.slice(0, Number(props.maxLength))
}
Expand All @@ -191,11 +189,15 @@ const updateValue = (value: string, trigger: InputFormatTrigger = 'onChange') =>
value = formatNumber(value, isDigit, isDigit)
}
if (props.formatter && trigger === props.formatTrigger) {
value = props.formatter(value)
const tempValue = props.formatter(value)
if (tempValue !== value) {
// #2178 & Taro #2642
emit('update:modelValue', value)
}
value = tempValue
}
if (value !== props.modelValue) {
emit('update:modelValue', value)
// emit('change', value);
}
}

Expand All @@ -205,7 +207,6 @@ const onFocus = (event: Event) => {
}
active.value = true
emit('focus', event)
// emit('update:modelValue', value);
}

const onBlur = (event: Event) => {
Expand All @@ -215,22 +216,14 @@ const onBlur = (event: Event) => {
setTimeout(() => {
active.value = false
}, 200)

const input = event.target as HTMLInputElement
let value = input.value
if (props.maxLength && value.length > Number(props.maxLength)) {
value = value.slice(0, Number(props.maxLength))
}
updateValue(getModelValue(), 'onBlur')
emit('blur', event)
// emit('update:modelValue', value);
}

const clear = (event: Event) => {
event.stopPropagation()
if (disabled.value) return
emit('update:modelValue', '', event)
// emit('change', '', event);
emit('clear', '', event)
}

Expand Down