Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide aliases for filter/pipe #166

Merged
merged 2 commits into from
Nov 14, 2018

Conversation

aalmiray
Copy link
Contributor

@aalmiray aalmiray commented Mar 19, 2018

Fix for #165


This change is Reviewable

@aalmiray aalmiray added this to the 2.0.0 milestone Mar 19, 2018
@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage remained the same at 55.942% when pulling 218ffab on aalmiray:pipe-filter-aliases into 2db9cde on jdeferred:master.

@aalmiray
Copy link
Contributor Author

Decided to bite the bullet and remove the "duplicate" versions of then and leave filter and pipe instead, given that this release already breaks binary compatibility.

@aalmiray
Copy link
Contributor Author

Do we need a method like the following one?

	<D_OUT, F_OUT> Promise<D_OUT, F_OUT, P> pipeFail(
	FailPipe<? super F, ? extends D_OUT, ? extends F_OUT, ? extends P> failPipe);

@aalmiray aalmiray requested a review from saturnism March 20, 2018 10:17
@saturnism
Copy link
Member

was this the last pr we needed to merge for 2.0? :D

@aalmiray
Copy link
Contributor Author

Yes, this is the one. All other PRs can wait post 2.0 IMHO

Copy link
Member

@saturnism saturnism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Member

@saturnism saturnism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 6 files at r1, 12 of 12 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@saturnism saturnism merged commit f2c2ab1 into jdeferred:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants