fix safari button inconsistency #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jdan
requested changes
Oct 24, 2022
style.css
Outdated
| @@ -9,6 +9,7 @@ | |||
| --surface: #c0c0c0; | |||
| --button-highlight: #ffffff; | |||
| --button-face: #dfdfdf; | |||
| --button-text: #000; | |||
There was a problem hiding this comment.
jdan
reviewed
Oct 24, 2022
style.css
Outdated
| box-sizing: border-box; | ||
| border: none; | ||
| background: var(--surface); | ||
| box-shadow: var(--border-raised-outer), var(--border-raised-inner); | ||
| border-radius: 0; | ||
| border-radius: 0px; |
There was a problem hiding this comment.
nit to use 0 over 0px. not currently linting for this
jdan
requested changes
Nov 13, 2022
| @@ -130,11 +131,14 @@ u { | |||
| button, | |||
| input[type="submit"], | |||
| input[type="reset"] { | |||
| all: unset; | |||
There was a problem hiding this comment.
Is this causing the text alignment to be off? https://98css-ntl6d9tp5-jdan.vercel.app/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I my name is João and this is my first PR. I saw this issue #124 open and decided to fix it. I loved this design system!
I waiting for feedbacks :)