Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optix7 bug causing access violations #28

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix optix7 bug causing access violations #28

wants to merge 1 commit into from

Commits on Mar 5, 2022

  1. Fix optix7 bug causing access violations 

    in `void RenderCore::SetMaterials( CoreMaterial* mat, const int materialCount )`
under `RenderCore_Optix7`, the `hostMaterialBuffer` is initialized with
size `materialCount`, but `materialBuffer` has size `materialCount` and
attribute `ON_DEVICE` set.

This triggers `if (location & ON_DEVICE) CopyToDevice();` and
eventually performs memcpy with size
`(materialCount + 512) * sizeof(CUDAMaterial)`, which can
occationally trigger access violation during tinyapp startup.
    @libreliu
    libreliu committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    f1c990f View commit details
    Browse the repository at this point in the history