Add Generate Test #137
Open
Add Generate Test #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
force-pushed
the
master
branch
3 times, most recently
from
d639e93
to
95b16cc
Compare
seveibar
commented
Jan 21, 2023
| const schema = fs.readFileSync("/out/zapatos/schema.d.ts", "utf8"); | ||
|
|
||
| t.truthy(schema.includes("export namespace foo {")); | ||
| t.truthy(schema.includes("export type Table = 'foo'")); |
There was a problem hiding this comment.
if it's okay with @jawj , I would also consider using t.snapshot instead of checking for specific lines via t.truthy here, that will guard really well against regressions, it will take a full snapshot of the schema.d.ts output and store it in a markdown file alongside this test. To update the snapshot you would run npm run ava ./tests/schemaGenerationExample.test.ts -u. The snapshot changes would then need to be approved in PR
seveibar
commented
Jan 21, 2023
| "target": "ES2019", | ||
| "module": "CommonJS", | ||
| "esModuleInterop": true, |
seveibar
commented
Jan 21, 2023
seveibar
commented
Jan 21, 2023
| module.exports = { | ||
| files: ["tests/**/*.test.ts"], | ||
| extensions: ["ts"], | ||
| require: ["esbuild-register"] |
There was a problem hiding this comment.
same as ts-node/register but faster
seveibar
commented
Jan 21, 2023
tests/fixtures/getTestDatabase.ts
Outdated
|
|
||
| export const getTestDatabase = getTestPostgresDatabaseFactory({ | ||
| postgresVersion: "14", | ||
| }); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple test case, should help prevent zapatos from breaking, especially if expanded upon.
Tests may help with monitoring the changes from PRs and preventing regressions.