Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote ETag #2222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Quote ETag #2222

wants to merge 2 commits into from

Conversation

adhesivee
Copy link

@tipsy
Copy link
Member

tipsy commented Apr 13, 2024

It seems to have some effect on existing tests:

Error:  Tests run: 30, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.579 s <<< FAILURE! -- in io.javalin.TestCompression
Error:  io.javalin.TestCompression.dynamic handler responds with 304 when ETag is set -- Time elapsed: 0.016 s <<< ERROR!
java.lang.RuntimeException: 
java.lang.Exception: Assertion error: 
expected: 304
 but was: 200

@tipsy tipsy force-pushed the master branch 4 times, most recently from 765b7d0 to 6faa186 Compare May 8, 2024 16:19
@tipsy
Copy link
Member

tipsy commented May 28, 2024

Do you want to try to get this fixed @adhesivee ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants