Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cors] Use JDK's URI class #2180

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

Playacem
Copy link
Member

@Playacem Playacem commented Mar 4, 2024

Todos:

  • tests for IPv4 addresses as an origin
  • tests for IPv6 addresses as an origin
  • harden port extraction especially for IPv6 addresses
  • Use URI class for port logic
  • complete plugin tests for IP address based origins

Fixes #2138 (once its done)

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 86.48649% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 86.53%. Comparing base (01a6d55) to head (34371f6).

Current head 34371f6 differs from pull request most recent head 6d6d995

Please upload reports for the commit 6d6d995 to get more accurate results.

Files Patch % Lines
...c/main/java/io/javalin/plugin/bundled/CorsUtils.kt 87.09% 0 Missing and 4 partials ⚠️
.../main/java/io/javalin/plugin/bundled/CorsPlugin.kt 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2180      +/-   ##
============================================
+ Coverage     86.42%   86.53%   +0.11%     
- Complexity     1299     1317      +18     
============================================
  Files           148      148              
  Lines          4029     4055      +26     
  Branches        504      513       +9     
============================================
+ Hits           3482     3509      +27     
+ Misses          331      329       -2     
- Partials        216      217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cors] Use JDK'S URI class for origin parsing
1 participant