Custom Static File Handling implementation #2174
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tipsy
reviewed
Mar 3, 2024
| import kotlin.io.path.Path | ||
| import kotlin.io.path.absolute | ||
|
|
||
| class ResourceHandlerImpl(val pvt: PrivateConfig) : ResourceHandler { |
There was a problem hiding this comment.
ResourceHandlerImpl -> DefaultResourceHandler or JavalinResourceHandler
| @@ -351,6 +353,7 @@ class TestStaticFiles { | |||
| } | |||
|
|
|||
| @Test | |||
| @Suppress("Javalin 7 will have an immutable instance") | |||
There was a problem hiding this comment.
I would prefer to push this out during 6x.
Comment on lines
+32
to
+41
| override fun canHandle(ctx: Context): Boolean = nonSkippedHandlers(ctx.req()).any { handler -> | ||
| return try { | ||
| fileOrWelcomeFile(handler, ctx.path()) != null | ||
| } catch (e: Exception) { | ||
| e.message?.contains("Rejected alias reference") == true || // we want to say these are un-handleable (404) | ||
| e.message?.contains("Failed alias check") == true || // we want to say these are un-handleable (404) | ||
| e.message?.contains("Path is outside of the base directory") == true // we want to say these are un-handleable (404) | ||
|
|
||
| } | ||
| } |
There was a problem hiding this comment.
It should be possible to simplify this a lot in the new setup
zugazagoitia
force-pushed
the
our-static-file-handler
branch
from
19d93d0
to
bed5ca5
Compare
zugazagoitia
force-pushed
the
our-static-file-handler
branch
from
bed5ca5
to
bcd12b8
Compare
tipsy
force-pushed
the
master
branch
4 times, most recently
from
765b7d0
to
6faa186
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR of the in-progress work to implement a non-Jetty dependent Static Files Handler, aiming to maintain maximum compatibility with the current API and Behaviour.
Related to #2164