Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _removeModels regression #3803

Merged
merged 1 commit into from
Sep 25, 2015

Commits on Sep 23, 2015

  1. Fix _removeModels regression

    Fixes jashkenas#3693.
    
    This leaves open the question of whether events triggered on the model
    during a ‘remove’ listener should also trigger on the model. Just
    something to revisit for V2.
    
    ```js
    col.on('other', (model) => {
    // Should this be triggered?
    });
    
    col.on('remove', (model) => {
    // If the model is really "removed" (we can't `#get` it anymore)
    // by the time this listener is called, then I'd argue that this
    // shouldn't trigger the 'other' event on the collection...
    model.trigger('other');
    });
    ```
    jridgewell committed Sep 23, 2015
    Configuration menu
    Copy the full SHA
    4b64eeb View commit details
    Browse the repository at this point in the history