Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2: Can of Promises #3729

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

v2: Can of Promises #3729

wants to merge 22 commits into from

Commits on Jul 21, 2015

  1. sync returns a Promise

    @au-phiware
    au-phiware committed Jul 21, 2015
    Configuration menu
    Copy the full SHA
    bfa268c View commit details
    Browse the repository at this point in the history

  2. Play nice with callbacks.

    @au-phiware
    au-phiware committed Jul 21, 2015
    Configuration menu
    Copy the full SHA
    e9f019e View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2015

  1. Any constructor or may provide a Promise.

    @au-phiware
    au-phiware committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    ecb606f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/jashkenas/backbone

    @au-phiware
    au-phiware committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    91227ee View commit details
    Browse the repository at this point in the history

  3. Router#execute may provide a Promise or trigger an error.

    @au-phiware
    au-phiware committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    9adf677 View commit details
    Browse the repository at this point in the history

  4. Permit routers to store metadata in History's handlers.

    @au-phiware
    au-phiware committed Jul 22, 2015
    Configuration menu
    Copy the full SHA
    5b39cf9 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2015

  1. Merge branch 'master' of https://github.com/jashkenas/backbone

    @au-phiware
    au-phiware committed Jul 24, 2015
    Configuration menu
    Copy the full SHA
    bdaa11b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2015

  1. Avoid conflict with potential reserved word. 

    I know ECMA wouldn't break the internet, but one day `catch` might be a
reserved word.

On the suggestion of @megawac
    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    ca27d88 View commit details
    Browse the repository at this point in the history

  2. Don't assume Promise is a global. 

    I see no need to refer to `Backbone.Promise` everywhere since the
reference from the arguments list isn't going to disappear.
    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    53e9555 View commit details
    Browse the repository at this point in the history

  3. Relax the definition of a Promise. 

    The Promise contract with Backbone is only two function, `then` and
`catch`, that both return another `Promise`.

On the suggestion of @megawac, see
jashkenas#3729 (comment)
    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    0d4fe5b View commit details
    Browse the repository at this point in the history

  4. Reject with an error when the error is known.

    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    0bee4c0 View commit details
    Browse the repository at this point in the history

  5. Event listener errors are handled by the caller of save, fetch, destroy.

    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    403bc44 View commit details
    Browse the repository at this point in the history

  6. Fix typo

    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    fb45026 View commit details
    Browse the repository at this point in the history

  7. Depend on promise.js. 

    See https://www.promisejs.org/
    @au-phiware
    au-phiware committed Jul 26, 2015
    Configuration menu
    Copy the full SHA
    820dd25 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2015

  1. Don't prescribe Promise implementation and fallback to global.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    509adab View commit details
    Browse the repository at this point in the history

  2. Clarify the extent of the use of Promises.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    747ffaa View commit details
    Browse the repository at this point in the history

  3. Revert "Any constructor or may provide a Promise." 

    This reverts commit ecb606f
at the suggestion of @akre54 see
jashkenas#3729 (comment)
    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    7eddccd View commit details
    Browse the repository at this point in the history

  4. Remove my 'mission statement'.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    2e8c79c View commit details
    Browse the repository at this point in the history

  5. Model#save rejects with validationError that is created by Model#set.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    0833ee7 View commit details
    Browse the repository at this point in the history

  6. Omit Promise from UMD wrapper.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    44bec7b View commit details
    Browse the repository at this point in the history

  7. Return callback result for correct event propagation.

    @au-phiware
    au-phiware committed Jul 27, 2015
    Configuration menu
    Copy the full SHA
    667f81d View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2015

  1. Merge branch 'master' of https://github.com/jashkenas/backbone

    @au-phiware
    au-phiware committed Aug 8, 2015
    Configuration menu
    Copy the full SHA
    21ab2ee View commit details
    Browse the repository at this point in the history