Fix validation on stale values #3947
Open
+19
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue - #2083
The cause of the issue is in this line
formik/packages/formik/src/Formik.tsx
Line 185 in 0f960aa
beause of assigning value from
stateRef.current
to thestate
variable this variable contains "old" value until next re-renderformik/packages/formik/src/Formik.tsx
Line 190 in 0f960aa
And then when
setFieldValue
andsetFieldTouched
are called consecutivelystateRef.current
references to updated value imediatelly aftersetFieldValue
call, butstate
variable is still references to the old value andsetFieldTouched
runs validation on that old valueUsing
stateRef.current
directly gurantees that actual values are taken