add PKCE support #110
Open
add PKCE support #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable with `pkce: true` when creating the strategy
kamronbatman
approved these changes
Feb 6, 2024
|
Great job, thank you!! |
|
Great job! @kamronbatman We need this feature as well, can we please merge and publish? Thanks |
|
Waiting on @jaredhanson to validate, add tests, and determine if there are any breaking changes. It sounds silly but many people rely on this. If I get time next week I'll work with him on tests. |
|
I tested this further. The call back on the backend doesn't pass the code challenge with it so it errors out. |
|
@MattPaymentus not sure what you mean, I have this code working against an authorization server that requires PKCE. |
|
Hello, we'd be interested on my side with this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable with
pkce: truewhen creating the strategy.Closes #83 and #56