Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify example #193

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

olsonpm
Copy link

@olsonpm olsonpm commented Dec 24, 2023

Provide a brief summary of the request in the title field above.

show source of LocalStrategy from module

Provide a detailed description of your use case, including as much

I had to look up the source in an express example repo to know where LocalStrategy was defined

detail as possible about what you are trying to accomplish and why.

add documentation to make it clearer for future devs how to use this module

If this patch closes an open issue, include a reference to the issue

n/a

Checklist

  • [x ] I have read the CONTRIBUTING guidelines.

  • I have added test cases which verify the correct operation of this feature or patch.
    n/a

  • I have added documentation pertaining to this feature or patch.
    n/a

  • [x ] The automated test suite ($ make test) executes successfully.

  • The automated code linting ($ make lint) executes successfully.

it seems make lint requires a bunch of loal tooling that I'm not going to install for this step. I suggest you install linting tools as devDependencies and run any linting processes using those

show source of LocalStrategy from module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant