Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional command arguments in the end for "attach" command #267

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DMaroo
Copy link

@DMaroo DMaroo commented Dec 6, 2022

This PR adds extra arguments at the end of "attach" command, and these will be forwarded on to perf verbatim. Therefore, we can now use the following command

$ magic-trace attach -p $(pidof foo) -trigger bar sleep 5

The perf command called under the hood would be

perf <args> sleep 5

Done in collaboration with @Mantra-7.

Fixes #230.

  * These commands will be forwarded to `perf`

Signed-off-by: Dhruv Maroo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support magic-trace attach -p ... [cmd] syntax
1 participant