Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -min-trigger-time to delay installing breakpoint #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xyene
Copy link
Member

@Xyene Xyene commented Apr 11, 2022

This allows capturing traces with -trigger symbols that get called
with very high (possibly bursty) frequency, where we otherwise migt
trigger before the snapshot buffer has a chance to fill up.

Closes #56.

Signed-off-by: Tudor Brindus [email protected]

This allows capturing traces with `-trigger` symbols that get called
with very high (possibly bursty) frequency, where we otherwise migt
trigger before the snapshot buffer has a chance to fill up.

Closes janestreet#56.

Signed-off-by: Tudor Brindus <[email protected]>
@Xyene Xyene requested a review from cgaebel April 11, 2022 12:48
Copy link
Contributor

@cgaebel cgaebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Consider leaving something in the FAQ pointing people to this solution. You don't actually have to do it, I am literally asking you to consider it.

@atulyagh03
Copy link

atulyagh03 commented May 10, 2024

Hi @Xyene, do these changes still work? I needed this feature for a project, so I tried copying its changes to a local clone (magic-trace version 1.2.1) but got this error while building:

image

I am not familiar enough with OCaml to understand how to resolve the 2nd error. Is it fixable?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

common events trigger too fast
3 participants