-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common events trigger too fast #56
Labels
Comments
Xyene
added
enhancement
New feature or request
good first issue
Good for newcomers
labels
Mar 23, 2022
Xyene
added a commit
to Xyene/magic-trace
that referenced
this issue
Apr 11, 2022
This allows capturing traces with `-trigger` symbols that get called with very high (possibly bursty) frequency, where we otherwise migt trigger before the snapshot buffer has a chance to fill up. Closes janestreet#56. Signed-off-by: Tudor Brindus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If I run a particular trace for an event I expect to be trigger very often (say expected 1000Hz) then as soon as magic trace starts recording, it stops. As a consequence I get a very limited history.
While my software trigger could be written to only probabalistically trigger I'd like it if magic trace had an option "refuse to trigger until we've been recording for TIME-SPAN".
The text was updated successfully, but these errors were encountered: