[0.14] Use raise_without_backtrace in Map, Set #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Map and Set use some exceptions for control flow that were being raised with plain `raise`. This meant that stack traces were being created for these exception that couldn't escape their outer function causing an unfortunate performance loss. Raising these exceptions with `raise_without_backtrace` avoids the performance problem. Signed-off-by: Geoff Reedy <[email protected]>
github-iron
added
the
forwarded-to-js-devs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #131 to 0.14
Map and Set use some exceptions for control flow that were being raised
with plain
raise. This meant that stack traces were being created forthese exception that couldn't escape their outer function causing an
unfortunate performance loss. Raising these exceptions with
raise_without_backtraceavoids the performance problem.Signed-off-by: Geoff Reedy [email protected]