closes #79 implement overrideMimeType as a noop #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| throw notImplementedError; | ||
| if (this.readyState >= MockXMLHttpRequest.LOADING) { | ||
| throw new MockError('xhr must not be LOADING or DONE.'); | ||
| } |
There was a problem hiding this comment.
Could we please explicitly check DONE just to make it a little clearer to understand what's going on at first sight 🙏
Should the passed mime affect the .responseType and related methods?
csimi
force-pushed
the
implement-overrideMimeType
branch
from
9df39ea
to
c6e0e97
Compare
|
@csimi @jameslnewell any traction on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://xhr.spec.whatwg.org/#the-overridemimetype()-method exception should be thrown in LOADING and DONE state, otherwise do nothing.