Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #101 : fixed compare URL with query string #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

smilexx
Copy link

@smilexx smilexx commented Feb 19, 2020

Hi. Added the ability to make a request with query parameters. Please see the request.
#101

Example:

mock.get('http://example.com/api/user', (req, res) => { return res.status(200).body('{"data": "1"}'); });

xhr.open('http://example.com/api/user?test=1');

@jameslnewell
Copy link
Owner

Thanks for your contribution!

Could you please add a test that would be failing without this fix.

How do you think we version this? Given the behaviour has been in the wild for a while, do you think this will break users who have come to expect the broken behaviour?

@bpinto
Copy link

bpinto commented Oct 20, 2020

Perhaps a better fix could be #101 (comment) ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants