Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relative ids when copying to clipboard and skip null relative ids when pasting #448

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivan-morandi-zupit
Copy link

@ivan-morandi-zupit ivan-morandi-zupit commented Feb 8, 2024

  • When copying, the relative id is initialized but never removed, thus when making multiple copy paste, the relative ids may match with multiple nodes. I removed the relative ids and used a local map to store the relative ids.
  • When pasting, the origin_node was not set to null correctly as the var scope is the entire function. As the scope is the entire function, if the relative id of the origin node is null, the origin node may had the previous value, which then creates links between nodes that never existed before.

@ivan-morandi-zupit ivan-morandi-zupit changed the title fix: fix relative ids when copying to clipboard and skip null relative ids when pasting fix relative ids when copying to clipboard and skip null relative ids when pasting Feb 8, 2024
@ivan-morandi-zupit ivan-morandi-zupit changed the title fix relative ids when copying to clipboard and skip null relative ids when pasting Fix relative ids when copying to clipboard and skip null relative ids when pasting Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant