Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed padding in mumble #61

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Shayan418
Copy link

Excess padding on right wasted too much space

Before

Screenshot 2022-03-25 200407

After

Screenshot 2022-03-25 205435

@Shayan418 Shayan418 changed the title fixed excess header padding in mumble fixed padding in mumble Mar 25, 2022
@jagannatharjun
Copy link
Owner

@Shayan418
Copy link
Author

thanks, updated base theme

@lpv11
Copy link

lpv11 commented Mar 25, 2022

You guys sure that works?
screenshot

I just did the 'build-mumble-dark.bat' thing. That's right, isn't it?

@Shayan418
Copy link
Author

It works, needs to be built with new icons to see the difference.

Before After
Screenshot 2022-03-26 023501 Screenshot 2022-03-26 023624
Screenshot 2022-03-26 024038 Screenshot 2022-03-26 024039

@lpv11
Copy link

lpv11 commented Mar 25, 2022

Well it's still spaced out af isn't it? :P Plus suggestion the dark-after icons are just a strain to the eye. Anyhow if you like it that way I can sure live with the before one. Miles ahead of any other.

@Shayan418
Copy link
Author

Well it's still spaced out af isn't it? :P Plus suggestion the dark-after icons are just a strain to the eye. Anyhow if you like it that way I can sure live with the before one. Miles ahead of any other.

do you mean spacing between icon and text ?
Screenshot 2022-03-26 120017

@lpv11
Copy link

lpv11 commented Mar 26, 2022

YES! Lmao, was that on purpose? Anyway don't mind me if you like it that way.

@Shayan418
Copy link
Author

YES! Lmao, was that on purpose? Anyway don't mind me if you like it that way.

lol no, I think these were the default values from original mumble theme.
I also fixed extremely huge slider.

Before After
Screenshot 2022-03-26 223510 Screenshot 2022-03-26 223416

 

@lpv11
Copy link

lpv11 commented Mar 26, 2022

Do you also happen to still have the source for the pink icons? 🤞🤞

@Truinto
Copy link

Truinto commented Nov 5, 2023

Nice. This is better. The checkboxes are a bit hard to see and I think the column text shouldn't vanish like that. Still the best theme I could find.

Your fork doesn't have the compiled file. I attached it for the people who don't want to figure out how to build.
mumble-dark-nowshed.zip

@lpv11
Copy link

lpv11 commented Nov 5, 2023

Nice. This is better. The checkboxes are a bit hard to see and I think the column text shouldn't vanish like that. Still the best theme I could find.

Your fork doesn't have the compiled file. I attached it for the people who don't want to figure out how to build. mumble-dark-nowshed.zip

Big thanks! Apparently I hadn't bothered building the file so I still used 'bugged' version up until your comment :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants