WIP: Data in json_value now a polymorphic class #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymorphic class. Fixes #405
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 89.52% 89.70% +0.17%
==========================================
Files 3 3
Lines 5336 5360 +24
==========================================
+ Hits 4777 4808 +31
+ Misses 559 552 -7 |
make sure the count function always returns a value even if an exception is raised.
…into 405-polymorphic
…into 405-polymorphic
jacobwilliams
changed the title
…into 405-polymorphic
…into 405-polymorphic
…into 405-polymorphic
…into 405-polymorphic
…into 405-polymorphic
…into 405-polymorphic
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 89.96% 90.13% +0.17%
==========================================
Files 6 6
Lines 5270 5294 +24
==========================================
+ Hits 4741 4772 +31
+ Misses 529 522 -7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405