Remove material cache, some materials seem not work when cloned #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scenemax3d
approved these changes
May 6, 2024
scenemax3d
pushed a commit
that referenced
this pull request
Jun 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just could not figure out why the material cloning doesn't work. I mean, AssetManager does it all the time... I don't know. Anyway, this slows down 20% loading the Bistro scene as GLB on my beefy computer. However, the memory problems are still solved with the texture cache.
Partially reverts #2128. But as said, the memory fix is still in and working.
As discussed in https://hub.jmonkeyengine.org/t/jmonkeyengine-v3-7-feature-freeze/47558/35.