Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notebook page to the SystemDS Website #8

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rebeccadias
Copy link
Collaborator

Adding notebook.html

@j143
Copy link
Owner

j143 commented Jul 18, 2020

Notifying the people you would like it to review via email or @ mentions! can help them find this issue.

@j143 j143 self-requested a review July 18, 2020 05:50
@j143
Copy link
Owner

j143 commented Jul 18, 2020

Now, we need to build notebook.html by passing in the content.

  1. For example, layout: page in page provides the complete layout with
    content as downloads.html. After the gulp, one might find the _site/downloads.html file
    with completely rendered html page.
    image

  2. The same needs to be done for the notebooks too.

  • It can go like this: layout: notebook. with
    file ./notebook-1.html contains only the notebook code.
  • And When you run gulp this should be rendered to _site/notebook-1.html.

This completest the task.

Thank you. :)

Copy link
Owner

@j143 j143 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the hard work, there are few more things you might find interesting to
make it completely functional.

@rebeccadias
Copy link
Collaborator Author

Okay sure Got it thanks! 👍

@rebeccadias
Copy link
Collaborator Author

image

@rebeccadias
Copy link
Collaborator Author

@j143 I have done the things you asked me to do . Please review it . Thank you.

@j143
Copy link
Owner

j143 commented Jul 18, 2020

Unfortunately, the task does not seem to be understood.

Please reread the #8 (comment)

After running gulp command, one should see webpage as #2 (comment)

@rebeccadias
Copy link
Collaborator Author

Thank You @j143 I will do it and get back to you .

@j143
Copy link
Owner

j143 commented Jul 18, 2020

The code looks a bit okay, I need to do some more work before merging this.

Is it possible to clean this PR, make sure only the file you have edited appears in the PR nothing else. 😅

Thank you.

@j143
Copy link
Owner

j143 commented Jul 19, 2020

Hi @rebeccadias can this PR be cleaned only showing the relevant work.

@rebeccadias
Copy link
Collaborator Author

Hi @j143 cleaned the PR . Thank You

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants