Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gemspec dependencies #27

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zinovyev
Copy link

Hi!

You've tried to solve the issue #15 by putting several dependencies into the Gemfile. But that's a bit broken for now cause you've occasionally left some of them unchanged in your gemspec file.

I suggest you do not to use Gemfile for the project dependencies at all. They will be included there from the gemspec anyway when the bundler will processes the gem.

Take a look at this page in documentation plz: http://bundler.io/v1.16/guides/creating_gem.html That's what I'm talking about:

Gemfile: Used to manage gem dependencies for our library’s development. This file contains a gemspec line meaning that Bundler will include dependencies specified in foodie.gemspec too. It’s best practice to specify all the gems that our library depends on in the gemspec.

@yyenigun
Copy link
Contributor

@zinovyev you are right. Thanks for your contribution.

@zinovyev
Copy link
Author

zinovyev commented Dec 25, 2017

@yyenigun I would suggest to update the rack version too (~> 2.0), if you don't mind: d508c13

Update rspec to solve dependencies issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants