repair hmain win32 process terminate judgment bug #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add win32 shared library version resource add win32 shared library lib prefix add unix/linux shared library version update nlohmann json to 3.11.3
remove unix/linux static library "_static" tab char convert 4 space
tab char Convert to 4 space
|
建议分成多个PR吧，有些可能为了兼容性不可被接受 |
添加win32共享库lib前缀并不会改变hv.lib，只会改变hv.dll，不会影响链接，如果这样也不行可以把这个和Linux去除_static这两项改动编辑去除，我是设置了Allowing edits by maintainers。没必要把每个小改动单独拆成多个PR把，还是说一个改动一个PR有什么其他优势必须这样做吗？ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加win32共享库版本资源是因为标准规范以及便于识别版本信息与某些杀软有文件资源特征要求
添加win32共享库lib前缀是因为hv.dll相比较libhv.dll辨识度更好也利于推广以及搜索引擎关键字匹配
添加unix/linux 环境共享库版本是因为SO-NAME标准化规范兼容性管理
更新nlohmann到23年发布的3.11.3 问题类似这个issues,在群里也遇到其他人被这个问题给坑了
去除unix/linux环境编译的静态库_static后缀是因为不便于标准编译参数自动.a与.so