Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why not update the nlohmann::json library? #453

Open
SuperBigYB opened this issue Oct 30, 2023 · 5 comments
Open

Why not update the nlohmann::json library? #453

SuperBigYB opened this issue Oct 30, 2023 · 5 comments

Comments

@SuperBigYB
Copy link
Contributor

The latest release version is 3.11.2.

@ithewei
Copy link
Owner

ithewei commented Oct 31, 2023

Do you need an upgraded version to support the new feature?

@SuperBigYB
Copy link
Contributor Author

release version 3.11.0:
String view support for all functions working on object keys (e.g., at or operator[]), avoiding unnecessary allocations.

@nanjo712
Copy link

新的nlohmann::json库的json类型定义与hv当前使用的有冲突,如果程序有一部分引入了json库,另一部分使用hv时会出现链接错误的问题
具体来说是新版的json类型模板参数最后多了一个class CustomBaseClass = void,导致符号不一致

@SuperBigYB
Copy link
Contributor Author

新的nlohmann::json库的json类型定义与hv当前使用的有冲突,如果程序有一部分引入了json库,另一部分使用hv时会出现链接错误的问题 具体来说是新版的json类型模板参数最后多了一个class CustomBaseClass = void,导致符号不一致

我直接将cpputil/json.hpp替换成最新版本的json.hpp, 目前使用没有问题.

@House-Men
Copy link

遇到同样的链接错误,排查老半天才发现问题出在hv的json版本与自己的json是同一个开源库导致ifndef宏约束形成声明与实现包含的json版本不同产生链接错误。。最后把自己fork的hv更新json解决了顺便提了pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants