Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timezone is not supported in digital signs #90

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

klpitshah
Copy link

when the certificate is added, there is an option to add signed by, reason, location and the signed date. timezone is not supported currently in the signed date. this change is to fix that.

when the certificate is added, there is an option to add signed by, reason, location and the signed date. timezone is not supported currently in the signed date. this change is to fix that.
@Snipx
Copy link
Contributor

Snipx commented Apr 18, 2022

Hi @klpitshah, thank you for your Pull Request!
Could you sign the CLA (https://github.com/itext/itext7/blob/develop/CONTRIBUTING.md#cla) and send to us?
We also kindly ask you to add a test to your fix/improvement - this will speed up the process of the PR review.

@klpitshah
Copy link
Author

klpitshah commented Apr 18, 2022 via email

@Snipx
Copy link
Contributor

Snipx commented Apr 18, 2022

Hey @klpitshah, I'm afraid the file didn't come through (don't see it in the GitHub or email)

@klpitshah
Copy link
Author

@Snipx
Copy link
Contributor

Snipx commented May 3, 2022

Hey @klpitshah, thank you for attaching the document. We'd need a printed-signed-scanned document or a proper digital signature though (as described at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement).
Would you be able to do either of those? Right now you added some stamps on the original document bit it's not a digital signature. Thanks

@klpitshah
Copy link
Author

klpitshah commented Oct 11, 2022 via email

@michaeldemey michaeldemey self-assigned this Feb 2, 2023
@michaeldemey
Copy link
Contributor

Hi @klpitshah ,

Unfortunately I don't see the new signed file anywhere you sent us on October 11th. Could you let me know where to find it or re-send me the file so we can proceed on this PR?

Kind regards,
Michaël.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants