Add support for platform 0, platform encoding 3 in TTF/OTF 'cmap' table #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform 0, encoding 3 is one of the ways to represent the Unicode BMP, and for our purposes can be handled in approximately the same way as (3, 1). It's used (among other places) in some of the fonts that ship with macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the ways to represent the Unicode BMP, and for our purposes can be handled in approximately the same way as (3, 1). It's used (among other places) in some of the fonts that ship with macOS.
The test font files included in this commit were generated from this file: https://github.com/RazrFalcon/ttf-parser/blob/337e7d1c08b06478a84c4345f4f289fc2cb9210c/tests/fonts-src/glyphs.ttx. I applied a few minor modifications to allow iText to open the font (required re-adding the
nametable) and to increase test coverage (by creating a version using a format 6 cmap subtable as well). The content in the linked repo is dual-licensed under MIT and Apache 2, so that should be OK.