Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanity check when null Field got no parent #24

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

gale93
Copy link

@gale93 gale93 commented Feb 18, 2022

Just a little sanity check that discards ( behaviour that I have seen in other PDF libraries ) the fields ( and their childs ) that are null and got null parent.

@yulian-gaponenko
Copy link
Member

Hi @gale93 ,
Thank you for your contribution!

In terms of acroform fields hierarchy processing, being lenient is a good idea indeed. Specification is sometimes vague in that area and from my experience it's relatively common to see not strictly valid PDFs from form-fields structure point of view.

One important thing for us in case of invalid PDFs handling is to have a regression test with that kind of file. Do you think you could add a test with such an example file? Let me know if you need any help in order to produce one.

Also, would you mind signing the Contributor License Agreement and send back to us? The details are available at https://itextpdf.com/en/how-buy/legal/itext-contributor-license-agreement - it's required in order to merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants