Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark sensitive environment variables for runners #665

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Mark sensitive environment variables for runners #665

wants to merge 6 commits into from

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Sep 12, 2022 •
edited

Suggested solution for iterative/cml#802, along with iterative/cml#1164

This was referenced Sep 12, 2022
Merged
Merged
@dacbd
Copy link
Contributor

dacbd commented Sep 12, 2022

⚠️ should require communication and migration instructions before being released ⚠️

dacbd
dacbd suggested changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@dacbd dacbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will require changes with: iterative/cml#1164 (review)

0x2b3bfa0
0x2b3bfa0 commented Oct 10, 2022
View reviewed changes
iterative/resource_runner.go Outdated Show resolved Hide resolved
iterative/resource_runner.go Outdated Show resolved Hide resolved
iterative/resource_runner.go Outdated Show resolved Hide resolved
iterative/resource_runner.go Outdated Show resolved Hide resolved
iterative/testdata/script_template_cloud_aws.golden Outdated Show resolved Hide resolved
iterative/testdata/script_template_cloud_azure.golden Outdated Show resolved Hide resolved
iterative/testdata/script_template_cloud_gcp.golden Outdated Show resolved Hide resolved
iterative/testdata/script_template_cloud_kubernetes.golden Outdated Show resolved Hide resolved
@0x2b3bfa0 0x2b3bfa0 requested review from dacbd and a team October 10, 2022 03:58
@dacbd dacbd added the blocked Dependent on something else label Oct 17, 2022
@casperdcl
Copy link
Contributor

Is this blocked by iterative/cml#802?

@0x2b3bfa0 0x2b3bfa0 removed the blocked Dependent on something else label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dacbd dacbd Awaiting requested review from dacbd

At least 1 approving review is required to merge this pull request.

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@0x2b3bfa0 @dacbd @casperdcl