Simplify bucket emptying mechanism #469
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
force-pushed
the
revert-revert-420
branch
from
014b239
to
1d0bc33
Compare
|
@0x2b3bfa0 seems to be failing in GCP The bucket you tried to delete is not empty.", Details:[]interface (nil), Body:""error":"code":409,"message":"The bucket you tried to delete is not empty.","errors":["message":"The bucket you tried to delete is not empty.","domain":"global","reason":"conflict"]", Header:http.Header(nil), Errors:[]googleapi.ErrorItemgoogleapi.ErrorItemReason:"conflict", Message:"The bucket you tried to delete is not empty."*** |
|
Ditto: #471 (comment) |
Ok! but not should be working rclone here also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #420 and #453, closes #459
It turns out that #459 happened because when some resources are already missing,
t.Read()fails and the emptying logic never runs. Still, needs extensive testing before merging.