Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin @npcz/magic to 1.3.12 #1465

Merged
merged 2 commits into from
May 27, 2024
Merged

Pin @npcz/magic to 1.3.12 #1465

merged 2 commits into from
May 27, 2024

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented May 27, 2024

Reverts #1412; @npcz/magic is by far our most fragile dependency, and pkg is deprecated: the combination of both is just catastrophic.

RangeError: Invalid typed array length: 4294835611
    at new Int8Array (<anonymous>)
    at Object.write (/snapshot/cml/node_modules/@npcz/magic/dist/magic-js.js:8:44744)
    at Object.write (/snapshot/cml/node_modules/@npcz/magic/dist/magic-js.js:8:151332)
    at doWritev (/snapshot/cml/node_modules/@npcz/magic/dist/magic-js.js:8:144274)
    at _fd_write (/snapshot/cml/node_modules/@npcz/magic/dist/magic-js.js:8:144487)
    at wasm://wasm/00123836:wasm-function[176]:0x1b8f4
    at wasm://wasm/00123836:wasm-function[188]:0x1bdb2
    at wasm://wasm/00123836:wasm-function[189]:0x1be5f
    at wasm://wasm/00123836:wasm-function[416]:0x2afbb
    at wasm://wasm/00123836:wasm-function[160]:0x1acfb

@0x2b3bfa0 0x2b3bfa0 added the bug Something isn't working label May 27, 2024
@0x2b3bfa0 0x2b3bfa0 requested a review from a team May 27, 2024 18:56
@0x2b3bfa0 0x2b3bfa0 self-assigned this May 27, 2024
@0x2b3bfa0 0x2b3bfa0 merged commit 0d8c31f into main May 27, 2024
11 of 12 checks passed
@0x2b3bfa0 0x2b3bfa0 deleted the pin-magic branch May 27, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant