Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to fmt-v10 #6783

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Conversation

daizhirui
Copy link

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Make the build work with fmt-10.2.0 such that "USE_SYSTEM_FMT" works again.

Copy link

update-docs bot commented May 3, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review May 5, 2024 06:26
@ssheorey
Copy link
Member

Hi @daizhirui can you check the Windows errors?

@daizhirui
Copy link
Author

@ssheorey I fix several issues and test it with my Windows laptop which uses CUDA 11.8:

  1. v10.2.1 is not compatible with CUDA on Windows: use v10.1.1 instead when BUILD_CUDA_MODULE is ON on Windows.
  2. add a missing formatter for cusolverStatus_t.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants