Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SYCL copy support to tensor #6764

Merged

Conversation

lumurillo
Copy link
Contributor

@lumurillo lumurillo commented Apr 22, 2024

Add a basic copy support for those tensor that needs to have their data in a SYCL device.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

The copy operation in the Device object wasn't implemented for SYCL devices. The copy logic is a basic one, and more use cases need to be covered.

Copy link

update-docs bot commented Apr 22, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey self-requested a review April 22, 2024 21:54
@ssheorey ssheorey force-pushed the lumurillo/add-sycl-copy-support-to-tensor branch from 17c73ae to 1b81fee Compare May 19, 2024 19:51
@ssheorey ssheorey merged commit 69786b6 into isl-org:main May 19, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants