Implement ComputeTriangleAreas, GetNonManifoldEdges and RemoveNonManifoldEdges in t::geometry::TriangleMesh #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes. |
nsaiapova
force-pushed
the
wip/remove-non-manifold-edges
branch
from
188c467
to
3b8f865
Compare
benjaminum
requested changes
Feb 26, 2024
| @@ -962,6 +962,18 @@ or has a negative value, it is ignored. | |||
| box = o3d.t.geometry.TriangleMesh.create_box() | |||
| top_face = box.select_by_index([2, 3, 6, 7]) | |||
| )"); | |||
| triangle_mesh.def("remove_non_manifold_edges", | |||
There was a problem hiding this comment.
Please add docstrings for python in the google format similar to other functions in this file. Examples are optional but very welcome 😄
ssheorey
reviewed
Mar 5, 2024
There was a problem hiding this comment.
Thanks @nsaiapova! Some minor comments. Feel free to ignore comments labeled with nit. We can chat about the algorithm....
| @@ -1212,5 +1212,84 @@ TEST_P(TriangleMeshPermuteDevices, SelectByIndex) { | |||
| box_untouched.GetTriangleIndices())); | |||
| } | |||
|
|
|||
| TEST_P(TriangleMeshPermuteDevices, RemoveNonManifoldEdges) { | |||
There was a problem hiding this comment.
Thanks for adding this - looks like we didn't have a test for this in legacy geometry.
nsaiapova
force-pushed
the
wip/remove-non-manifold-edges
branch
from
3b8f865
to
20782b4
Compare
benjaminum
reviewed
Apr 16, 2024
|
|
||
| triangle_mesh.def("compute_triangle_areas", | ||
| &TriangleMesh::ComputeTriangleAreas, | ||
| "Compute triangle areas and save it as \"areas\" " |
There was a problem hiding this comment.
Just a suggestion. An example cold show how to access the new attribute and sum it to get the total surface area.
| @pytest.mark.parametrize("int_t", (o3c.int32, o3c.int64)) | ||
| @pytest.mark.parametrize("float_t", (o3c.float32, o3c.float64)) | ||
| def test_compute_triangle_areas(device, int_t, float_t): | ||
| torus = o3d.t.geometry.TriangleMesh.create_torus(2, 1, 6, 3, float_t, int_t, |
There was a problem hiding this comment.
Thanks for adding more unit tests
|
Hi @nsaiapova can you take a look at the failing CI checks? |
nsaiapova
force-pushed
the
wip/remove-non-manifold-edges
branch
from
20782b4
to
aa7a3ce
Compare
Split the logic from ComputeSurfaceArea into a helper static function and introduce a new method which computes triangle areas and writes the resulting tensor into attributes of the mesh.
nsaiapova
force-pushed
the
wip/remove-non-manifold-edges
branch
from
aa7a3ce
to
110aebd
Compare
... and t::geometry::TriangleMesh::GetNonManifoldEdges methods. The methods are defined in geometry::TriangleMesh API. t::geometry::TriangleMesh::GetNonManifoldEdges mimics the logic of the legacy method. t::geometry::TriangleMesh::RemoveNonManifoldEdges follows the logic of the legacy method but there are a few differences: * the main difference is that the outer while-loop is removed. I don't see how after the first iteration any edge can have more than 2 adjacent triangles, which makes the further iterations unnecessary. * I count triangles with non-negative areas immediately and do not rely on the total number of adjacent triangles (which would also include triangles marked for removal). * To choose a triangle with the minimal area out of the existing adjacent triangles I use a heap structure.
nsaiapova
force-pushed
the
wip/remove-non-manifold-edges
branch
from
110aebd
to
e25faf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a few methods which are available with the geometry::TriangleMesh API.
Type
Motivation and Context
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
In this PR three methods for t::geometry::TriangleMesh are implemented.
t::geometry::TriangleMesh::ComputeTriangleAreas
Split the logic from ComputeSurfaceArea into a helper static function
and introduce a new method which computes triangle areas and writes the
resulting tensor into attributes of the mesh.
IIUC, in geometry::TriangleMesh the corresponding function is GetSurfaceArea(std::vector &areas), where the areas are filled with the triangle areas.
t::geometry::TriangleMesh::GetNonManifoldEdges mimics the logic of the legacy method.
t::geometry::TriangleMesh::RemoveNonManifoldEdges follows the logic of
the legacy method but there are a few differences:
see how after the first iteration any edge can have more than 2
adjucent triangles, which makes the further iterations unnecessary.
on the total number of adjacent triangles (which would also include
triangles marked for removal).
adjacent triangles I use a heap structure.