Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

follow a more common format #105

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

follow a more common format #105

wants to merge 4 commits into from

Conversation

ma7555
Copy link

@ma7555 ma7555 commented Dec 13, 2020

return xmin, ymin, xmax, ymax instead of x, y, width, heigth

@MattyB95
Copy link
Contributor

@ma7555 Why have you removed the - x and - y from the width and height. That is there as part of the fix for Pull Request #94 unless something has happened since that I am not aware of.

Also, I'm not sure how much I agree with this change suggestion; these names suggest coordinates which is not the case for the width and height. However, I haven't looked at this project in detail in a little while, just my two cents worth.

@ma7555
Copy link
Author

ma7555 commented Dec 14, 2020

Hello @MattyB95,

The pull request totally replaces the width and height with xmax and ymax points so the box in returned as 4 points, not 2 points + width + height. I don't understand the -x and -y you are refering to but the whole line has been omitted.

This format is what is returned by most recent face detection models like mobileface, retinaface, etc..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants