refactor(icon): remove addition style #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `stroke-width: 32px` line never applies because of the following line where we apply the CSS Variable. All versions of browsers that Ionicons supports also support CSS Variables, so the `stroke-width: 32px` line isn't needed anymore.
liamdebeasi
requested review from
a team and
brandyscarney
and removed request for
a team
brandyscarney
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
stroke-width: 32pxline never applies because of the following line where we apply the CSS Variable. All versions of browsers that Ionicons supports also support CSS Variables, so thestroke-width: 32pxline isn't needed anymore.