Skip to content

Commit

Permalink
fix: fix inconsistent node versions (#1399)
Browse files Browse the repository at this point in the history
  • Loading branch information
NozomuIkuta committed May 11, 2023
1 parent c39d143 commit 4348a61
Show file tree
Hide file tree
Showing 12 changed files with 15 additions and 13 deletions.
6 changes: 4 additions & 2 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,12 @@ It is of course fine to use non-English language, when you open a PR to translat
- Work in the `src` folder and **DO NOT** checkin `dist` in the commits.

- If adding new feature:

- Add accompanying test case.
- Provide convincing reason to add this feature. Ideally you should open a suggestion issue first and have it greenlighted before working on it.

- If fixing a bug:

- Provide detailed description of the bug in the PR. Live demo preferred.
- Add appropriate test coverage if applicable.

Expand All @@ -34,6 +36,7 @@ It is of course fine to use non-English language, when you open a PR to translat
- Make sure `npm test` passes. (see [development setup](#development-setup))

### Work Step Example

- Fork the repository from [intlify/vue-i18n-next](https://github.com/intlify/vue-i18n-next) !
- Create your topic branch from `master`: `git branch my-new-topic origin/master`
- Add codes and pass tests !
Expand All @@ -43,7 +46,7 @@ It is of course fine to use non-English language, when you open a PR to translat

## Development Setup

You will need [Node.js](http://nodejs.org) **version 12+**, and [PNPM](https://pnpm.io).
You will need [Node.js](http://nodejs.org) **version 16+**, and [PNPM](https://pnpm.io).

We also recommend installing [ni](https://github.com/antfu/ni) to help switching between repos using different package managers. `ni` also provides the handy `nr` command which running npm scripts easier.

Expand All @@ -53,7 +56,6 @@ After cloning the repo, run:
$ pnpm i # install the dependencies of the project
```


A high level overview of tools used:

- [TypeScript](https://www.typescriptlang.org/) as the development language
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
"typescript": "^4.9.4"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"private": true,
"gitHooks": {
Expand Down
2 changes: 1 addition & 1 deletion packages/core-base/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@intlify/vue-devtools": "workspace:*"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyCoreBase",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@intlify/core-base": "workspace:*"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyCore",
Expand Down
2 changes: 1 addition & 1 deletion packages/devtools-if/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"@intlify/shared": "workspace:*"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyDevToolsIf",
Expand Down
2 changes: 1 addition & 1 deletion packages/message-compiler/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"source-map": "0.6.1"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyMessageCompiler",
Expand Down
2 changes: 1 addition & 1 deletion packages/petite-vue-i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"vue": "^3.0.0"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "PetiteVueI18n",
Expand Down
2 changes: 1 addition & 1 deletion packages/shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"module": "dist/shared.mjs",
"types": "dist/shared.d.ts",
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyShared",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-devtools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"@intlify/shared": "workspace:*"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyVueDevtools",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-i18n-bridge/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"@vue/composition-api": "^1.0.0-rc.1"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "VueI18nBridge",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-i18n-core/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"vue": "^3.0.0"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "IntlifyVueI18nCore",
Expand Down
2 changes: 1 addition & 1 deletion packages/vue-i18n/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"vue": "^3.0.0"
},
"engines": {
"node": ">= 14"
"node": ">= 16"
},
"buildOptions": {
"name": "VueI18n",
Expand Down

0 comments on commit 4348a61

Please sign in to comment.