Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: seo canonical link support #45

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Conversation

Sebastian-Haehnlein
Copy link
Contributor

@Sebastian-Haehnlein Sebastian-Haehnlein commented Dec 9, 2019

PR Type

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • CI-related changes
  • Documentation content changes
  • application / infrastructure changes
  • Other... Please describe:

What Is the Current Behavior?

Issue Number: ISREST-932

What Is the New Behavior?

canonical link support

Does this PR Introduce a Breaking Change?

  • Yes
  • No

dhhyi
dhhyi previously approved these changes Dec 11, 2019
Copy link
Collaborator

@dhhyi dhhyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the way to go. 👍

@dhhyi
Copy link
Collaborator

dhhyi commented Dec 11, 2019

@shauke merge when you are ready 😉

@dhhyi dhhyi added this to In progress in SEO via automation Dec 11, 2019
@dhhyi dhhyi added the feature New feature or request label Dec 11, 2019
@dhhyi dhhyi added this to the 0.17 milestone Dec 11, 2019
SEO automation moved this from In progress to Review in progress Dec 11, 2019
@shauke shauke force-pushed the feature/seo-canonical-link branch 2 times, most recently from c31d677 to 0fd095b Compare December 12, 2019 15:29
@shauke shauke assigned shauke and unassigned Sebastian-Haehnlein Dec 13, 2019
Copy link
Member

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be consistent canonical links for category pages too.
The current solution creates canonical links like

<link rel="canonical" href="http://localhost:4200/category/Cameras-Camcorders">

for category pages with subcategories
and canonical links like

<link rel="canonical" href="http://localhost:4200/category/Cameras-Camcorders.832?view=grid">

for category pages with product lists (leaf categories).
The ?view=grid parameter should not be part of the canonical link.

Copy link
Member

@shauke shauke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It needs to be clarified if canonical links for Mastered Products should be handled in the same way as in the Responsive Starter Store. See:

<isif condition="#ProductBO:isMastered#">
	<issetcanonicallink
		scope="request"
		name="CanonicalLink"
		action="ViewProduct-Start"
		parameters="#ParameterList(Parameter('SKU', ProductBO:ProductBOMaster:SKU))#">
<iselse>
	<issetcanonicallink
		scope="request"
		name="CanonicalLink"
		action="ViewProduct-Start"
		parameters="#ParameterList(Parameter('SKU', ProductBO:SKU))#">
</isif>

@shauke
Copy link
Member

shauke commented Dec 17, 2019

Empty canonical links should probably not be created, e.g. for the /home or /register or /contact pages. Example:

<link rel="canonical">

For content pages like About Us it seems to work well without specific handling.

@Sebastian-Haehnlein Sebastian-Haehnlein self-assigned this Dec 18, 2019
@shauke shauke removed their assignment Dec 18, 2019
@dhhyi dhhyi removed their request for review December 19, 2019 05:43
@fmalcher
Copy link
Collaborator

fmalcher commented Jan 1, 2020

Possibly related: angular/angular#34605

SEO automation moved this from Review in progress to Reviewer approved Jan 8, 2020
@shauke shauke removed the request for review from fmalcher January 8, 2020 13:37
@shauke shauke merged commit 7e19179 into develop Jan 8, 2020
SEO automation moved this from Reviewer approved to Done Jan 8, 2020
@shauke shauke deleted the feature/seo-canonical-link branch January 8, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
SEO
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants