-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: seo canonical link support #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be the way to go. 👍
@shauke merge when you are ready 😉 |
dd94364
to
835f304
Compare
c31d677
to
0fd095b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should be consistent canonical links for category pages too.
The current solution creates canonical links like
<link rel="canonical" href="http://localhost:4200/category/Cameras-Camcorders">
for category pages with subcategories
and canonical links like
<link rel="canonical" href="http://localhost:4200/category/Cameras-Camcorders.832?view=grid">
for category pages with product lists (leaf categories).
The ?view=grid
parameter should not be part of the canonical link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be clarified if canonical links for Mastered Products should be handled in the same way as in the Responsive Starter Store. See:
<isif condition="#ProductBO:isMastered#">
<issetcanonicallink
scope="request"
name="CanonicalLink"
action="ViewProduct-Start"
parameters="#ParameterList(Parameter('SKU', ProductBO:ProductBOMaster:SKU))#">
<iselse>
<issetcanonicallink
scope="request"
name="CanonicalLink"
action="ViewProduct-Start"
parameters="#ParameterList(Parameter('SKU', ProductBO:SKU))#">
</isif>
Empty canonical links should probably not be created, e.g. for the
For content pages like About Us it seems to work well without specific handling. |
0fd095b
to
f2384ff
Compare
Possibly related: angular/angular#34605 |
79faf58
to
25f5544
Compare
8a2bbe1
to
0aec842
Compare
PR Type
What Is the Current Behavior?
Issue Number: ISREST-932
What Is the New Behavior?
canonical link support
Does this PR Introduce a Breaking Change?