Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make edit button border consistent #9243

Merged

Conversation

IlyaMckay
Copy link
Contributor

This commit address the issue by changing a button class to the requested one
This change affects the appearance of the button border line

Closes #9238

Fix the UX bug

Technical

Were changed the button class to meet the requirement style

Screenshot

9238

Testing

Same as screenshot

Stakeholders

@RayBB

This commit address the issue by changing a button class to the
requested one
This change affects the appearance of the button border line
@RayBB
Copy link
Collaborator

RayBB commented May 9, 2024

@IlyaMckay when you want a look a this please mark it as ready for review (not draft) and tag me!

@IlyaMckay
Copy link
Contributor Author

IlyaMckay commented May 9, 2024

@IlyaMckay when you want a look a this please mark it as ready for review (not draft) and tag me!

@RayBB I was waiting to be assigned as a new commiting process required:
"3. Ask to be assigned to an issue by including the text "assign me" in your comment

  • Include any questions you have about completing the issue
  1. Staff will review the solution proposed by your draft pull request and will then assign the issue to you."

So, the PR is ready for review.

@IlyaMckay IlyaMckay marked this pull request as ready for review May 9, 2024 16:13
Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
image

@mekarpeles can you merge?

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label May 9, 2024
@mekarpeles mekarpeles merged commit c373a3b into internetarchive:master May 13, 2024
4 checks passed
@cdrini cdrini changed the title Fix: This change was requested in order to standardize Open Library's buttons, #9238 Make edit button border consistent May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize Book Page "Edit" btn style
3 participants