Added a QR icon in Share Modal that opens to QR code on click #9233
+109
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merwhite11
force-pushed
the
452/feature/add-qr-to-share-modal
branch
from
3416158
to
2e9a182
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9233 +/- ##
==========================================
+ Coverage 15.89% 16.11% +0.22%
==========================================
Files 90 91 +1
Lines 4732 4785 +53
Branches 824 829 +5
==========================================
+ Hits 752 771 +19
- Misses 3468 3498 +30
- Partials 512 516 +4 ☔ View full report in Codecov by Sentry. |
merwhite11
force-pushed
the
452/feature/add-qr-to-share-modal
branch
2 times, most recently
from
43e71a7
to
52650ba
Compare
merwhite11
force-pushed
the
452/feature/add-qr-to-share-modal
branch
from
f317528
to
06d8feb
Compare
merwhite11
force-pushed
the
452/feature/add-qr-to-share-modal
branch
from
fc03faf
to
6939cc6
Compare
for more information, see https://pre-commit.ci
|
@jimchamp Could you review this when you get the chance? Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #452
Feature: Adds a QR code icon to the share modal on books page. On icon click, a new tab opens with the QR code image.
Refactor: Changed styling of Share Modal so that for small -> tablet sized screens, the share modal icons appear larger and in two rows.
Technical
Installed qrcode dependency in requirements.txt
Imported qrcode and io in api.py for use in create_qrcode handler.
Testing
docker compose run --rm home make test: passing with warningsdocker compose run --rm home pytest openlibrary/plugins/importapi/tests/test_import_validator.py: passing with warningsdocker compose run --rm home npm run lint: passing with deprecation warningsScreenshot
I can change the size of the icons if these are too large. I can also change the breakpoint for when to switch from large 2-row icons, to smaller single row icons. Currently I have the icons in 2 rows for everything tablet and smaller.
Stakeholders
@jimchamp
Thank you for the help!