7615/refactor/lazybookcard cleanup requests #9217
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #9005
Closes #7615 (First checklist item)
Refactored
LazyBookCard
so that after it fetches/isbn/...
, it fetches/search.json?q=edition_key:{key}&fields=key,author_name
instead of making multiple requests for the author names.Testing
For the user, the behavior remains the same. I tested if the
/barcodescanner
page recognizes books and correctly fetches and displays the name, ISBN, authors, and cover. I also tested if the page properly redirects when the page has areturnTo
parameter/barcodescanner?returnTo=/isbn/$$$$
. This has been tested using different books with differing number of authors.Screenshot
Stakeholders
@cdrini