Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete some unused templates discovered by i18n process #9207

Merged

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented May 2, 2024

Closes #9057

These files aren't references, so let's delete them and remove them from messages.pot

Technical

  • openlibrary/templates/type/macro/*, openlibrary/templates/type/rawtext/*
    • Legacy OL types we no longer support ; they should also be deleted from infogami at some point. These are legacy from back when OL used to be developed on OL! So these just contain e.g. dead JS files or dead python templates.
    • 133 type macros
    • 46 type rawtext
  • openlibrary/macros/EditButtonsMacros.html
    • Only used by type/macro, type/rawtext
  • openlibrary/macros/SRPCoverImage.html: Unreferenced
  • openlibrary/macros/databarAuthor.html: Unreferenced (I confirmed it's not used on our author page; it's clearly some ancient thing. Doesn't even use the same templating language as the rest of our html files!).
  • openlibrary/templates/admin/profile.html: Unreferenced
  • openlibrary/templates/lib/markdown.html: This file itself is unreferenced; it seems like all its markup was at some point moved out of the repo and into infogami at https://openlibrary.org/help/markdown
  • Also removed some CSS classes/etc that were no longer being referenced.

Testing

Confirmed things load correctly!

Screenshot

Stakeholders

@cdrini cdrini marked this pull request as ready for review May 2, 2024 00:59
These files aren't references, so let's delete them and remove them from messages.pot
@cdrini cdrini force-pushed the 9057/refactor/delete-old-templates branch from cb2c7d1 to c451d44 Compare May 2, 2024 17:13
@mekarpeles mekarpeles self-assigned this May 6, 2024
@mekarpeles mekarpeles added the Priority: 2 Important, as time permits. [managed] label May 6, 2024
@cdrini cdrini assigned mekarpeles and unassigned mekarpeles May 10, 2024
@cdrini
Copy link
Collaborator Author

cdrini commented May 13, 2024

Auto-merging this one ; it's been open for 2w and is causing a bit of confusion for folks and I'll be away shortly and need to wrap up some loose ends! Feel free to give a post-merge review 👍

@cdrini cdrini merged commit c674965 into internetarchive:master May 13, 2024
4 checks passed
@cdrini cdrini deleted the 9057/refactor/delete-old-templates branch May 23, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 2 Important, as time permits. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete some unused templates discovered by i18n process
2 participants