change made to address issue #7073, add original publication date #9159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l publication date, the commit adds functionality similiar to existing publication date function, the original publication date box is optional to fill in and only serves as an option when adding new works via the form.
for more information, see https://pre-commit.ci
|
FYI there is a documented property The example from #7073 , https://openlibrary.org/works/OL17449W.json already has this property set. Unfortunately it's currently: The language around the issue (and associates first publish date with the work, which is appropriate, but the code in this PR appears to be setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7073
Adds a feature for adding the original publication date when adding works via the add work form
Technical
The feature is currently completely optional and has no input validation
Testing
Ran with automated tests and linting, also would require user testing via trying the add new work form.
Screenshot
Stakeholders
@FinixFighter