Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Book Page "Edit" btn style #9238

Closed
Tracked by #1184
mekarpeles opened this issue May 8, 2024 · 2 comments · Fixed by #9243
Closed
Tracked by #1184

Standardize Book Page "Edit" btn style #9238

mekarpeles opened this issue May 8, 2024 · 2 comments · Fixed by #9243
Assignees
@IlyaMckay
Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

Problem

When one first lands on the book page, the edit button looks like this, which has the classes/styles we want:
Screenshot 2024-05-08 at 7 39 43 AM

But when we scroll down, the Edit button changes styles to have a thinner boarder. We want to keep similar classes / visual design in this view:
Screenshot 2024-05-08 at 7 40 05 AM

This only applies to the Edit button when the button transitions into the navigation header bar, nothing needs to change about the "Last edited by" text, etc.

Relevant URL(s)

https://openlibrary.org/books/OL30162974M/A_Court_of_Mist_and_Fury

Reproducing the bug

  1. Go to ...
  2. Do ...
  • Expected behavior:
  • Actual behavior:

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Notes from this Issue's Lead

Proposal & constraints

Related files

Stakeholders
@mekarpeles mekarpeles added Type: Bug Something isn't working. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Affects: Experience Issues relating directly to service design & patrons experience Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Theme: Book Page Issues related to the redesign of the books page labels May 8, 2024
@mekarpeles mekarpeles mentioned this issue May 8, 2024
Open
16 tasks
@IlyaMckay
Copy link
Contributor

I can make necessary changes. Please, assign me.

@IlyaMckay IlyaMckay mentioned this issue May 8, 2024
Merged
@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label May 9, 2024
@mekarpeles
Copy link
Member Author

Thank you @IlyaMckay!

@RayBB RayBB added Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. and removed Needs: Response Issues which require feedback from lead labels May 9, 2024
mekarpeles added a commit that referenced this issue May 13, 2024
@mekarpeles
Merge pull request #9243 from IlyaMckay/9238/fix/edit-btn-style
c373a3b 
Fix: This change was requested in order to standardize Open Library's buttons, #9238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IlyaMckay IlyaMckay

Labels
Affects: Experience Issues relating directly to service design & patrons experience Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Book Page Issues related to the redesign of the books page Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make edit button border consistent IlyaMckay/openlibrary
3 participants
@RayBB @mekarpeles @IlyaMckay