Use 32 threads per warp for dot test on Arc #885
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return is_xpu() and triton.runtime.driver.active.get_current_target()[1]['has_fp64'] | ||
|
|
||
| def threads_per_warp_dpas(): | ||
| return 16 if xpu_has_fp64() else 32 |
| @@ -34,6 +34,11 @@ def is_hip(): | |||
| def is_xpu(): | |||
| return not is_interpreter() and triton.runtime.driver.active.get_current_target()[0] == "xpu" | |||
|
|
|||
| def xpu_has_fp64(): | |||
| return is_xpu() and triton.runtime.driver.active.get_current_target()[1]['has_fp64'] | |||
There was a problem hiding this comment.
I prefer assert is_xpu() then return is_xpu() and ..., WDYT?
There was a problem hiding this comment.
I left asserts out in this draft and made the functions general because I was not sure whether we would want to have a more general threads per warp function (especially for compatibility with upstream) vs a specific function we expect to only call in xpu mode. Let me finish cataloguing the issues under Arc so we can see how extensively we need to modify tests, then I will revisit making these specialized XPU functions vs generic free functions to properly configure the test (/ kernel launch) based on the available hardware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower threads per warp is causing a shared memory resource error on A770:
This change resolves some of those issues but I am investigating a few others that popped up after the original threads per warp change (af0a308). I think those have to do with newly enabled multiplication tests, however.
#890