[UT] add skiplist in pvc w/ lts for skipped cases #1156
Conversation
|
About the convert function from agama to driver type, I can not think of another way but hard code the agama version in the function. @vlad-penkin could you give some tips if this is not a good practice? |
AshburnLee
force-pushed
the
lijunhui/pvc_lts_skiplist
branch
from
5361a29
to
ee16ac7
Compare
| @@ -0,0 +1,169 @@ | |||
| # https://github.com/intel/intel-xpu-backend-for-triton/issues/986 | |||
There was a problem hiding this comment.
Why this skip list contains more test cases that the existing default skip list? The run (https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/9214379486) shows that we do not need to skip more tests than the current skip list has.
scripts/capture-hw-details.sh
Outdated
| @@ -50,3 +46,50 @@ if [ "$QUIET" = false ]; then | |||
| echo "AGAMA_VERSION=$AGAMA_VERSION" | |||
| echo "GPU_DEVICE=$GPU_DEVICE" | |||
| fi | |||
|
|
|||
| agama_to_driver_type() { | |||
There was a problem hiding this comment.
I think we do not need to detect what driver (rolling or lts) is currently installed. Instead, a specific runner should set an environment variable either to select a skip list or to select a release stream (if you still need it for some reason).
There was a problem hiding this comment.
@AshburnLee could you please address @pbchekin comments?
There was a problem hiding this comment.
Thanks~ I'm working on other PR's comments.
There was a problem hiding this comment.
So from what I understand, in this PR, I just need to:
- remove
agama_to_driver_type()andxpu_is_pvc(), - Run
test_triton.shand collectFAILEDcases from the log, and put thoseFAILEDin a skiplistpvc_lts/....txt
Please confirm that I am right @pbchekin , thank you.
There was a problem hiding this comment.
And the automation script #1196 is not in this scope
There was a problem hiding this comment.
Yes, you can use test report from https://github.com/intel/intel-xpu-backend-for-triton/actions/runs/9507147050. This is a run where all errors are ignored and full test report is attached as artifact.
all: passed: 17460, failed: 129, skipped: 400, xfailed: 1240, total: 19229, fixme: 12 pass rate (w/o xfailed): 97.06%
scripts/capture-hw-details.sh
Outdated
| @@ -50,3 +46,50 @@ if [ "$QUIET" = false ]; then | |||
| echo "AGAMA_VERSION=$AGAMA_VERSION" | |||
| echo "GPU_DEVICE=$GPU_DEVICE" | |||
| fi | |||
|
|
|||
| agama_to_driver_type() { | |||
There was a problem hiding this comment.
@AshburnLee could you please address @pbchekin comments?
AshburnLee
force-pushed
the
lijunhui/pvc_lts_skiplist
branch
from
ee16ac7
to
2bad257
Compare
AshburnLee
force-pushed
the
lijunhui/pvc_lts_skiplist
branch
from
2bad257
to
7b48c2e
Compare
Functionality
This PR add all
SKIPPEDFAILED cases to a skiplist inscripts/skiplist/pvc_lts/language 112 failed cases
operators 17 failed cases
Solves issue #986
Result
Now there are no SKIPPED cases on PVC w/ LTS driverNotes
1. This PR only skips SKIPPED cases, no FAILED cases2. Agama version is captured formintel-level-zero-gpu, because I found the original way won't work on my local PVC w/ LTS, the change in my PR works.