Update actions versions #2260
Update actions versions #2260
Conversation
Fix GitHub Actions Node.js deprecation warnings
|
Pretty nice that you addressed the deprecation warnings in the actions. I think one should also take the opportunity to adjust the versions in the other actions, not only in the Windows EXE build action. I have also seen that setup-python provides a cache for the dependencies, which could save a few seconds for the build. Would you perhaps like to take the opportunity to implement this as well? |
|
I have updated the PR per your suggestion. |
.github/workflows/documentation.yml
Outdated
| with: | ||
| python-version: 3.12 | ||
| cache: 'pip' |
There was a problem hiding this comment.
| cache: 'pip' | |
| cache: 'pipenv' |
We actually use Pipenv for dependency management, Pip is only used in the Workflows to install Pipenv.
There was a problem hiding this comment.
Thanks! I wasn't quite sure which one to use. Does that apply to "packages.yml" as well?
There was a problem hiding this comment.
Thanks! Good point, "packages.yml" does acutally not install the Instaloader dependencies, it just installs the dependencies required for the packaging, and does so with Pip. However, the pip cache mechanism seems to be using the requirements.txt file which we do not have, so for packages.yml the cache should better be disabled.
There was a problem hiding this comment.
Sounds good. I removed the cache entry from the "packages.yml" file.
There was a problem hiding this comment.
Looks good, thank you very much!
Fix GitHub Actions Node.js deprecation warnings
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-python@v2.Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-python@v2.This PR bumps actions/checkout to v4, and actions/setup-python to v5.